Jelajahi Sumber

AMBARI-8819 Unit tests for dashboard views (additional patch). (atkach)

Andrii Tkach 10 tahun lalu
induk
melakukan
6bc7c69ebb

+ 3 - 1
ambari-web/app/views/main/dashboard/config_history_view.js

@@ -190,7 +190,9 @@ App.MainConfigHistoryView = App.TableView.extend(App.TableServerViewMixin, {
   refresh: function () {
     var self = this;
     this.set('filteringComplete', false);
-    this.get('controller').load().done(this.refreshDone);
+    this.get('controller').load().done(function () {
+      self.refreshDone.apply(self);
+    });
   },
 
   /**

+ 8 - 4
ambari-web/test/views/main/dashboard/widget_test.js

@@ -140,24 +140,28 @@ describe('App.DashboardWidgetView', function () {
 
   describe("#showEditDialog()", function () {
     var obj = Em.Object.create({
-      observeNewThresholdValue: Em.K,
+      observeThresh1Value: Em.K,
+      observeThresh2Value: Em.K,
       thresh1: '1',
       thresh2: '2'
     });
     before(function () {
-      sinon.spy(obj, 'observeNewThresholdValue');
+      sinon.spy(obj, 'observeThresh1Value');
+      sinon.spy(obj, 'observeThresh2Value');
       sinon.stub(dashboardWidgetView.get('parentView'), 'getUserPref').returns({
         complete: Em.K
       });
     });
     after(function () {
-      obj.observeNewThresholdValue.restore();
+      obj.observeThresh1Value.restore();
+      obj.observeThresh2Value.restore();
       dashboardWidgetView.get('parentView').getUserPref.restore();
     });
     it("open popup", function () {
       var popup = dashboardWidgetView.showEditDialog(obj);
       popup.onPrimary();
-      expect(obj.observeNewThresholdValue.calledOnce).to.be.true;
+      expect(obj.observeThresh1Value.calledOnce).to.be.true;
+      expect(obj.observeThresh2Value.calledOnce).to.be.true;
       expect(dashboardWidgetView.get('thresh1')).to.equal(1);
       expect(dashboardWidgetView.get('thresh2')).to.equal(2);
       expect(dashboardWidgetView.get('parentView').getUserPref.calledOnce).to.be.true;