AMBARI-4629. Delimiter Comma not handled while creating NodeManager log

and local directories (Eugene Chekanskiy via aonishuk)

ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/yarn.py

@@ -71,8 +71,15 @@ def yarn(name = None):
             group=params.user_group,
             recursive=True
   )
-
-  Directory([params.nm_local_dirs, params.nm_log_dirs, params.yarn_log_dir_prefix],
+  Directory(params.nm_local_dirs.split(','),
+            owner=params.yarn_user,
+            recursive=True
+  )
+  Directory(params.nm_log_dirs.split(','),
+            owner=params.yarn_user,
+            recursive=True
+  )
+  Directory(params.yarn_log_dir_prefix,
             owner=params.yarn_user,
             recursive=True
   )

ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py

@@ -194,10 +194,18 @@ class TestHistoryServer(RMFTestCase):
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/local1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/hadoop/yarn/log',
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/log1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/var/log/hadoop-yarn',
       owner = 'yarn',
       recursive = True,

ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py

@@ -53,10 +53,18 @@ class TestMapReduce2Client(RMFTestCase):
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/local1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/hadoop/yarn/log',
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/log1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/var/log/hadoop-yarn',
       owner = 'yarn',
       recursive = True,

ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py

@@ -194,10 +194,18 @@ class TestNodeManager(RMFTestCase):
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/local1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/hadoop/yarn/log',
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/log1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/var/log/hadoop-yarn',
       owner = 'yarn',
       recursive = True,

ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py

@@ -134,10 +134,18 @@ class TestResourceManager(RMFTestCase):
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/local1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/hadoop/yarn/log',
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/log1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/var/log/hadoop-yarn',
       owner = 'yarn',
       recursive = True,

ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py

@@ -53,10 +53,18 @@ class TestYarnClient(RMFTestCase):
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/local1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/hadoop/yarn/log',
       owner = 'yarn',
       recursive = True,
     )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/log1',
+      owner = 'yarn',
+      recursive = True,
+    )
     self.assertResourceCalled('Directory', '/var/log/hadoop-yarn',
       owner = 'yarn',
       recursive = True,

ambari-server/src/test/python/stacks/2.0.6/configs/default.json

@@ -448,7 +448,7 @@
         "yarn-site": {
             "yarn.nodemanager.disk-health-checker.min-healthy-disks": "0.25", 
             "yarn.nodemanager.container-executor.class": "org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor", 
-            "yarn.nodemanager.local-dirs": "/hadoop/yarn/local", 
+            "yarn.nodemanager.local-dirs": "/hadoop/yarn/local,/hadoop/yarn/local1",
             "yarn.resourcemanager.resource-tracker.address": "c6402.ambari.apache.org:8025", 
             "yarn.nodemanager.remote-app-log-dir-suffix": "logs", 
             "yarn.resourcemanager.hostname": "c6402.ambari.apache.org", 
@@ -466,7 +466,7 @@
             "yarn.nodemanager.log-aggregation.compression-type": "gz", 
             "yarn.nodemanager.log.retain-second": "604800", 
             "yarn.nodemanager.delete.debug-delay-sec": "0", 
-            "yarn.nodemanager.log-dirs": "/hadoop/yarn/log", 
+            "yarn.nodemanager.log-dirs": "/hadoop/yarn/log,/hadoop/yarn/log1",
             "yarn.nodemanager.health-checker.interval-ms": "135000", 
             "yarn.resourcemanager.am.max-attempts": "2", 
             "yarn.nodemanager.remote-app-log-dir": "/app-logs", 

ambari-server/src/test/python/stacks/2.1.1/YARN/test_apptimelineserver.py

@@ -88,10 +88,18 @@ class TestAppTimelineServer(RMFTestCase):
                               owner = 'yarn',
                               recursive = True,
                               )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/local1',
+                              owner = 'yarn',
+                              recursive = True,
+                              )
     self.assertResourceCalled('Directory', '/hadoop/yarn/log',
                               owner = 'yarn',
                               recursive = True,
                               )
+    self.assertResourceCalled('Directory', '/hadoop/yarn/log1',
+                              owner = 'yarn',
+                              recursive = True,
+                              )
     self.assertResourceCalled('Directory', '/var/log/hadoop-yarn',
                               owner = 'yarn',
                               recursive = True,