AMBARI-11722. Infinite spinner after reopening RU window on Finalize stage (akovalenko)

ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js

@@ -117,6 +117,18 @@ App.MainAdminStackAndUpgradeController = Em.Controller.extend(App.LocalStorage,
     return App.get('apiPrefix') + '/clusters/' + App.get('clusterName') + '/stack_versions?fields=ClusterStackVersions/*';
   }.property('App.clusterName'),
 
+  /**
+   * Determines if list of services with checks that failed and were skipped by user during the upgrade is loaded
+   * @type {boolean}
+   */
+  areSkippedServiceChecksLoaded: false,
+
+  /**
+   * List of services with checks that failed and were skipped by user during the upgrade
+   * @type {array}
+   */
+  skippedServiceChecks: [],
+
   init: function () {
     this.initDBProperties();
   },

ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs

@@ -93,11 +93,11 @@
                 <p>{{t admin.stackUpgrade.finalize.message.upgrade}}</p>
               {{/if}}
 
-              {{#if view.areSkippedServiceChecksLoaded}}
-                {{#if view.skippedServiceChecks.length}}
+              {{#if areSkippedServiceChecksLoaded}}
+                {{#if skippedServiceChecks.length}}
                   <div>{{t admin.stackUpgrade.finalize.message.skippedServiceChecks}}</div>
                   <ul>
-                    {{#each serviceName in view.skippedServiceChecks}}
+                    {{#each serviceName in skippedServiceChecks}}
                       <li>{{serviceName}}</li>
                     {{/each}}
                   </ul>

ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js

@@ -63,18 +63,6 @@ App.upgradeWizardView = Em.View.extend({
    */
   outsideView: true,
 
-  /**
-   * Determines if list of services with checks that failed and were skipped by user during the upgrade is loaded
-   * @type {boolean}
-   */
-  areSkippedServiceChecksLoaded: false,
-
-  /**
-   * List of services with checks that failed and were skipped by user during the upgrade
-   * @type {array}
-   */
-  skippedServiceChecks: [],
-
   /**
    * Downgrade should be available only if target version higher than current, so we can't downgrade
    * when downgrade already started
@@ -251,18 +239,22 @@ App.upgradeWizardView = Em.View.extend({
   }.observes('App.clusterName'),
 
   getSkippedServiceChecks: function () {
-    if (this.get('isFinalizeItem') && !this.get('areSkippedServiceChecksLoaded')) {
-      var self = this;
-      App.ajax.send({
-        name: 'admin.upgrade.service_checks',
-        sender: this,
-        data: {
-          upgradeId: this.get('controller.upgradeId')
-        },
-        success: 'getSkippedServiceChecksSuccessCallback'
-      }).complete(function () {
-          self.set('areSkippedServiceChecksLoaded', true);
-        });
+    if (this.get('isFinalizeItem')) {
+      if (!this.get('controller.areSkippedServiceChecksLoaded')) {
+        var self = this;
+        App.ajax.send({
+          name: 'admin.upgrade.service_checks',
+          sender: this,
+          data: {
+            upgradeId: this.get('controller.upgradeId')
+          },
+          success: 'getSkippedServiceChecksSuccessCallback'
+        }).complete(function () {
+            self.set('controller.areSkippedServiceChecksLoaded', true);
+          });
+      }
+    } else {
+      this.set('controller.areSkippedServiceChecksLoaded', false);
     }
   }.observes('isFinalizeItem'),
 
@@ -282,7 +274,7 @@ App.upgradeWizardView = Em.View.extend({
           }
         });
         skippedServiceChecks = skippedServiceChecks.uniq();
-        this.set('skippedServiceChecks', skippedServiceChecks);
+        this.set('controller.skippedServiceChecks', skippedServiceChecks);
       }
     }
   },

ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js

@@ -649,7 +649,7 @@ describe('App.upgradeWizardView', function () {
     var cases = [
       {
         isFinalizeItem: false,
-        areSkippedServiceChecksLoaded: false,
+        areSkippedServiceChecksLoaded: true,
         ajaxSendCallCount: 0,
         areSkippedServiceChecksLoadedResult: false,
         title: 'no ajax request should be sent away from Finalize step'
@@ -685,13 +685,13 @@ describe('App.upgradeWizardView', function () {
 
     cases.forEach(function (item) {
       it(item.title, function () {
-        view.set('areSkippedServiceChecksLoaded', item.areSkippedServiceChecksLoaded);
+        view.set('controller.areSkippedServiceChecksLoaded', item.areSkippedServiceChecksLoaded);
         view.reopen({
           isFinalizeItem: item.isFinalizeItem
         });
         view.propertyDidChange('isFinalizeItem');
         expect(App.ajax.send.callCount).to.equal(item.ajaxSendCallCount);
-        expect(view.get('areSkippedServiceChecksLoaded')).to.equal(item.areSkippedServiceChecksLoadedResult);
+        expect(view.get('controller.areSkippedServiceChecksLoaded')).to.equal(item.areSkippedServiceChecksLoadedResult);
         if (item.ajaxSendCallCount) {
           expect(App.ajax.send.firstCall.args[0].data.upgradeId).to.equal(1);
         }
@@ -783,7 +783,7 @@ describe('App.upgradeWizardView', function () {
 
     it('should set an array of service names from tha latest service checks step', function () {
       view.getSkippedServiceChecksSuccessCallback(data);
-      expect(view.get('skippedServiceChecks')).to.eql(['ZooKeeper', 'YARN', 'Hive']);
+      expect(view.get('controller.skippedServiceChecks')).to.eql(['ZooKeeper', 'YARN', 'Hive']);
     });
 
   });