AMBARI-8802. Kerberos Wizard -> Configure Identities page: Show properties for only installed services. (jaimin)

ambari-web/app/controllers/main/admin/kerberos/step4_controller.js

@@ -61,18 +61,25 @@ App.KerberosWizardStep4Controller = App.WizardStep7Controller.extend(App.AddSecu
   setStepConfigs: function(configs) {
     var selectedService = App.StackService.find().findProperty('serviceName', 'KERBEROS');
     var configCategories = selectedService.get('configCategories');
-    this.prepareConfigProperties(configs);
-    this.get('stepConfigs').pushObject(this.createServiceConfig(configCategories, configs));
+    this.get('stepConfigs').pushObject(this.createServiceConfig(configCategories, this.prepareConfigProperties(configs)));
     this.set('selectedService', this.get('stepConfigs')[0]);
   },
 
   /**
-   * 
-   * @param {} configs
+   * Filter configs by installed services. Set property value observer.
+   * Set realm property with value from previous configuration step.
+   * Set appropriate category for all configs.
+   *
+   * @param {App.ServiceCofigProperty[]} configs
+   * @returns {App.ServiceConfigProperty[]}
    */
   prepareConfigProperties: function(configs) {
     var self = this;
     var realmValue = this.get('wizardController').getDBProperty('serviceConfigProperties').findProperty('name', 'realm').value;
+    var installedServiceNames = ['Cluster'].concat(App.Service.find().mapProperty('serviceName'));
+    configs = configs.filter(function(item) {
+      return installedServiceNames.contains(item.get('serviceName'));
+    });
     configs.findProperty('name', 'realm').set('value', realmValue);
     configs.findProperty('name', 'realm').set('defaultValue', realmValue);
     
@@ -89,8 +96,15 @@ App.KerberosWizardStep4Controller = App.WizardStep7Controller.extend(App.AddSecu
       if (property.get('serviceName') == 'Cluster') property.set('category', 'General');
       else property.set('category', 'Advanced');
     });
+
+    return configs;
   },
 
+  /**
+   * Sync up values between inherited property and its reference.
+   * 
+   * @param {App.ServiceConfigProperty} configProperty
+   */
   spnegoPropertiesObserver: function(configProperty) {
     var self = this;
     this.get('stepConfigs')[0].get('configs').forEach(function(config) {

ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js

@@ -49,5 +49,89 @@ describe('App.KerberosWizardStep4Controller', function() {
       expect(controller.createServiceConfig([], [])).be.instanceof(App.ServiceConfig);
     });
   });
+
+  describe('#prepareConfigProperties', function() {
+    
+    before(function() {
+      var controller = App.KerberosWizardStep4Controller.create({
+        wizardController: {
+          getDBProperty: function() {
+            return Em.A([
+              Em.Object.create({ name: 'realm', value: 'realm_value' })
+            ]);
+          }
+        }
+      });
+      sinon.stub(App.Service, 'find').returns(Em.A([
+        { serviceName: 'HDFS' }
+      ]));
+      this.result = controller.prepareConfigProperties(properties);
+    });
+
+    after(function() {
+      App.Service.find.restore();
+    });
+
+    var properties = Em.A([
+      Em.Object.create({ name: 'realm', value: '', serviceName: 'Cluster' }),
+      Em.Object.create({ name: 'spnego_keytab', value: 'spnego_keytab_value', serviceName: 'Cluster' }),
+      Em.Object.create({ name: 'hdfs_keytab', value: '', serviceName: 'HDFS', observesValueFrom: 'spnego_keytab' }),
+      Em.Object.create({ name: 'falcon_keytab', value: 'falcon_keytab_value', serviceName: 'FALCON' }),
+      Em.Object.create({ name: 'mapreduce_keytab', value: 'mapreduce_keytab_value', serviceName: 'MAPREDUCE2' }),
+      Em.Object.create({ name: 'hdfs_principal', value: 'hdfs_principal_value', serviceName: 'HDFS' })
+    ]);
+    
+    var propertyValidationCases = [
+      {
+        property: 'spnego_keytab',
+        e: [
+          { key: 'category', value: 'General' },
+          { key: 'observesValueFrom', absent: true },
+        ]
+      },
+      {
+        property: 'realm',
+        e: [
+          { key: 'category', value: 'General' },
+          { key: 'value', value: 'realm_value' },
+        ]
+      },
+      {
+        property: 'hdfs_keytab',
+        e: [
+          { key: 'value', value: 'spnego_keytab_value' },
+          { key: 'observesValueFrom', value: 'spnego_keytab' },
+        ]
+      }
+    ];
+    
+    var absentPropertiesTest = ['falcon_keytab', 'mapreduce_keytab'];
+    
+    it('should contains properties only for installed services', function() {
+      expect(this.result.mapProperty('serviceName').uniq()).to.be.eql(['Cluster', 'HDFS']);
+    });
+
+    absentPropertiesTest.forEach(function(item) {
+      it('property `{0}` should be absent'.format(item), function() {
+        expect(this.result.findProperty('name', item)).to.be.undefined;
+      });
+    }, this);
+    
+    propertyValidationCases.forEach(function(test) {
+      it('property {0} should be created'.format(test.property), function() {
+        expect(this.result.findProperty('name', test.property)).to.be.ok;
+      });
+      test.e.forEach(function(expected) {
+        it('property `{0}` should have `{1}` with value `{2}`'.format(test.property, expected.key, expected.value), function() {
+          if (!!expected.absent) {
+            expect(this.result.findProperty('name', test.property)).to.not.have.deep.property(expected.key);
+          } else {
+            expect(this.result.findProperty('name', test.property)).to.have.deep.property(expected.key, expected.value);
+          }
+        }, this);
+      }, this);
+    });
+    
+  });
 });