AMBARI-8114. Unknown component state shown and empty during save configs. (onechiporenko)

ambari-web/app/controllers/main/service/info/configs.js

@@ -1383,6 +1383,8 @@ App.MainServiceInfoConfigsController = Em.Controller.extend(App.ServerValidatorM
 
   /**
    * Show save configs popup
+   * @method showSaveConfigsPopup
+   * @return {App.ModalPopup}
    */
   showSaveConfigsPopup: function (header, flag, message, messageClass, value, status, urlParams) {
     var self = this;
@@ -1390,7 +1392,7 @@ App.MainServiceInfoConfigsController = Em.Controller.extend(App.ServerValidatorM
       this.set('forceTransition', flag);
       self.loadStep();
     }
-    App.ModalPopup.show({
+    return App.ModalPopup.show({
       header: header,
       primary: Em.I18n.t('ok'),
       secondary: null,
@@ -1435,17 +1437,31 @@ App.MainServiceInfoConfigsController = Em.Controller.extend(App.ServerValidatorM
                 context: view
               });
             },
+            /**
+             * Map components for their hosts
+             * Return format:
+             * <code>
+             *   {
+             *    host1: [component1, component2, ...],
+             *    host2: [component3, component4, ...]
+             *   }
+             * </code>
+             * @return {object}
+             */
             setComponents = function (item, components) {
               item.host_components.forEach(function (c) {
                 var name = c.HostRoles.host_name;
                 if (!components[name]) {
                   components[name] = [];
-                } else {
-                  components[name].push(App.format.role(item.ServiceComponentInfo.component_name));
                 }
+                components[name].push(App.format.role(item.ServiceComponentInfo.component_name));
               });
               return components;
             },
+            /**
+             * Map result of <code>setComponents</code> to array
+             * @return {{name: string, components: string}[]}
+             */
             setHosts = function (components) {
               var hosts = [];
               Em.keys(components).forEach(function (key) {
@@ -1490,7 +1506,7 @@ App.MainServiceInfoConfigsController = Em.Controller.extend(App.ServerValidatorM
           this.set('isLoaded', true);
         },
         didInsertElement: function () {
-          App.ajax.send({
+          return App.ajax.send({
             name: 'components.filter_by_status',
             sender: this,
             data: {

ambari-web/test/controllers/main/service/info/config_test.js

@@ -262,7 +262,7 @@ describe("App.MainServiceInfoConfigsController", function () {
     });
   });
 
-  describe("rollingRestartStaleConfigSlaveComponents", function () {
+  describe("#rollingRestartStaleConfigSlaveComponents", function () {
     var tests = [
       {
         componentName: {
@@ -1388,7 +1388,7 @@ describe("App.MainServiceInfoConfigsController", function () {
     });
   });
 
-  describe("setCompareDefaultGroupConfig", function() {
+  describe("#setCompareDefaultGroupConfig", function() {
     beforeEach(function() {
       sinon.stub(mainServiceInfoConfigsController, "getComparisonConfig").returns("compConfig");
       sinon.stub(mainServiceInfoConfigsController, "getMockComparisonConfig").returns("mockConfig");
@@ -1419,4 +1419,50 @@ describe("App.MainServiceInfoConfigsController", function () {
     });
 
   });
+
+  describe('#showSaveConfigsPopup', function () {
+
+    var bodyView;
+
+    describe('#bodyClass', function () {
+      beforeEach(function() {
+        sinon.stub(App.ajax, 'send', Em.K);
+        // default implementation
+        bodyView = mainServiceInfoConfigsController.showSaveConfigsPopup().get('bodyClass').create({
+          parentView: Em.View.create()
+        });
+      });
+
+      afterEach(function() {
+        App.ajax.send.restore();
+      });
+
+      describe('#componentsFilterSuccessCallback', function () {
+        it('check components with unknown state', function () {
+          bodyView = mainServiceInfoConfigsController.showSaveConfigsPopup('', true, '', {}, '', 'unknown', '').get('bodyClass').create({
+            parentView: Em.View.create()
+          });
+          bodyView.componentsFilterSuccessCallback({
+            items: [
+              {
+                ServiceComponentInfo: {
+                  total_count: 4,
+                  started_count: 2,
+                  installed_count: 1,
+                  component_name: 'c1'
+                },
+                host_components: [
+                  {HostRoles: {host_name: 'h1'}}
+                ]
+              }
+            ]
+          });
+          var unknownHosts = bodyView.get('unknownHosts');
+          expect(unknownHosts.length).to.equal(1);
+          expect(unknownHosts[0]).to.eql({name: 'h1', components: 'C1'});
+        });
+      });
+    });
+  });
+
 });