Przeglądaj źródła

AMBARI-20823. Remove user input from invalid renderer error message (Attila Magyar via adoroszlai)

Attila Magyar 8 lat temu
rodzic
commit
3c844cad8d

+ 1 - 2
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java

@@ -132,8 +132,7 @@ public abstract class BaseResourceDefinition implements ResourceDefinition {
               || name.contains("zero_padding")) {
       return new MetricsPaddingRenderer(name);
     } else {
-      throw new IllegalArgumentException("Invalid renderer name: " + name +
-          " for resource of type: " + m_type);
+      throw new IllegalArgumentException("Invalid renderer name for resource of type " + m_type);
     }
   }
 

+ 1 - 1
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java

@@ -140,7 +140,7 @@ public class BaseResourceDefinitionTest {
       resource.getRenderer("foo");
       fail("Should have thrown an exception due to invalid renderer type");
     } catch (IllegalArgumentException e) {
-      // expected
+      assertEquals("Invalid renderer name for resource of type Service", e.getMessage());
     }
   }