AMBARI-9042 Failed, redundant requests after refresh on services page. (atkach)

ambari-web/app/app.js

@@ -144,7 +144,7 @@ module.exports = Em.Application.create({
   isHaEnabled: function () {
     var isHDFSInstalled = App.Service.find().findProperty('serviceName','HDFS');
     return !!isHDFSInstalled && !this.HostComponent.find().someProperty('componentName', 'SECONDARY_NAMENODE');
-  }.property('router.clusterController.isLoaded', 'isStackServicesLoaded'),
+  }.property('router.clusterController.isLoaded', 'router.clusterController.dataLoadList.serviceMetrics'),
 
   /**
    * If ResourceManager High Availability is enabled

ambari-web/app/routes/main.js

@@ -554,7 +554,6 @@ module.exports = Em.Route.extend({
         route: '/summary',
         connectOutlets: function (router, context) {
           var item = router.get('mainServiceItemController.content');
-          router.get('updateController').updateServiceMetric(Em.K);
           //if service is not existed then route to default service
           if (item.get('isLoaded')) {
             router.get('mainServiceItemController').connectOutlet('mainServiceInfoSummary', item);

ambari-web/app/templates/main/service/info/summary/master_components.hbs

@@ -17,7 +17,7 @@
 }}
 <tr class="hidden"><td></td></tr>
 {{#each comp in view.mastersComp}}
-  <tr {{bindAttr class="comp.isZkfc:component-small"}}>
+  <tr {{bindAttr class="comp.isSubComponent:component-small"}}>
     <td>
       <a href="#" {{action showDetails comp.host}} title="{{unbound comp.host.publicHostName}}" rel="UsageTooltip">
         {{#if comp.displayNameAdvanced}}

ambari-web/app/views/main/service/info/summary.js

@@ -474,7 +474,11 @@ App.MainServiceInfoSummaryView = Em.View.extend(App.UserPref, {
     return gangliaUrl;
   }.property('App.router.clusterController.gangliaUrl', 'service.serviceName'),
 
-  didInsertElement:function () {
+  willInsertElement: function () {
+    App.router.get('updateController').updateServiceMetric(Em.K);
+  },
+
+  didInsertElement: function () {
     var svcName = this.get('service.serviceName');
     if (svcName) {
       this.constructGraphObjects(App.service_graph_config[svcName.toLowerCase()]);

ambari-web/app/views/main/service/services/hdfs.js

@@ -43,28 +43,20 @@ App.MainDashboardServiceHdfsView = App.MainDashboardServiceView.extend({
     },
     templateName: require('templates/main/service/info/summary/master_components'),
     mastersComp: function() {
-      if (App.get('isHaEnabled')) {
-        // return all Namenodes followed by its ZKFC
-        var namenodes = this.get('parentView.service.hostComponents').filter(function(comp){
-          return comp.get('isMaster') && comp.get('componentName') !== 'JOURNALNODE';
-        });
-        var zkfcs = this.get('parentView.service.hostComponents').filter(function(comp){
-          return comp.get('componentName') == 'ZKFC';
-        });
-        var nnZkfc = [];
-        namenodes.forEach( function(namenode) {
-          nnZkfc.push(namenode);
-          var zkfc = zkfcs.findProperty('host.publicHostName', namenode.get('host.publicHostName'));
+      var masterComponents = [];
+      var zkfcs = this.get('parentView.service.hostComponents').filterProperty('componentName', 'ZKFC');
+
+      this.get('parentView.service.hostComponents').forEach(function (comp) {
+        if (comp.get('isMaster') && comp.get('componentName') !== 'JOURNALNODE') {
+          masterComponents.push(comp);
+          var zkfc = zkfcs.findProperty('hostName', comp.get('hostName'));
           if (zkfc) {
-            nnZkfc.push(zkfc.set('isZkfc', true));
+            zkfc.set('isSubComponent', true);
+            masterComponents.push(zkfc);
           }
-        });
-        return nnZkfc;
-      } else {
-        return this.get('parentView.service.hostComponents').filter(function(comp){
-          return comp.get('isMaster') && comp.get('componentName') !== 'JOURNALNODE';
-        });
-      }
+        }
+      });
+      return masterComponents;
     }.property('parentView.service.hostComponents.length')
   }),
 

ambari-web/test/app_test.js

@@ -168,15 +168,15 @@ describe('App', function () {
     });
 
     it('if hadoop stack version higher than 2 then isHaEnabled should be true', function () {
-      App.set('isStackServicesLoaded', true);
+      App.propertyDidChange('isHaEnabled');
       expect(App.get('isHaEnabled')).to.equal(true);
-      App.set('isStackServicesLoaded', false);
     });
     it('if cluster has SECONDARY_NAMENODE then isHaEnabled should be false', function () {
       App.store.load(App.HostComponent, {
         id: 'SECONDARY_NAMENODE',
         component_name: 'SECONDARY_NAMENODE'
       });
+      App.propertyDidChange('isHaEnabled');
       expect(App.get('isHaEnabled')).to.equal(false);
     });
   });

ambari-web/test/controllers/main/host/details_test.js

@@ -634,9 +634,8 @@ describe('App.MainHostDetailsController', function () {
       });
       var data = {Clusters: {desired_configs: {'core-site': {tag: 1}}}};
       App.HostComponent.find().clear();
-      App.set('isStackServicesLoaded', true);
+      App.propertyDidChange('isHaEnabled');
       expect(controller.constructConfigUrlParams(data)).to.eql(['(type=core-site&tag=1)']);
-      App.set('isStackServicesLoaded', false);
       App.store.load(App.HostComponent, {
         id: 'SECONDARY_NAMENODE_host1',
         component_name: 'SECONDARY_NAMENODE'
@@ -648,6 +647,7 @@ describe('App.MainHostDetailsController', function () {
         id: 'HBASE',
         service_name: 'HBASE'
       });
+      App.propertyDidChange('isHaEnabled');
       var data = {Clusters: {desired_configs: {'hbase-site': {tag: 1}}}};
       expect(controller.constructConfigUrlParams(data)).to.eql(['(type=hbase-site&tag=1)']);
       App.Service.find().clear();
@@ -770,7 +770,7 @@ describe('App.MainHostDetailsController', function () {
         id: 'HDFS',
         service_name: 'HDFS'
       });
-      App.set('isStackServicesLoaded', true);
+      App.propertyDidChange('isHaEnabled');
       expect(controller.setZKConfigs(configs, 'host1:2181', [])).to.be.true;
       expect(configs).to.eql({"core-site": {
         "ha.zookeeper.quorum": "host1:2181"
@@ -779,7 +779,7 @@ describe('App.MainHostDetailsController', function () {
         id: 'SECONDARY_NAMENODE_host1',
         component_name: 'SECONDARY_NAMENODE'
       });
-      App.set('isStackServicesLoaded', false);
+      App.propertyDidChange('isHaEnabled');
     });
     it('hbase-site is present', function () {
       var configs = {'hbase-site': {}};