Browse Source

AMBARI-7028. Config History: need to set notes for the new SCV when reverting back via 'Make Current' action.(xiwang)

Xi Wang 10 years ago
parent
commit
2dc55f08fe

+ 2 - 1
ambari-web/app/messages.js

@@ -1410,7 +1410,7 @@ Em.I18n.translations = {
     'on the Ambari Server host to make the JDBC driver available and to enable testing the database connection.',
     'on the Ambari Server host to make the JDBC driver available and to enable testing the database connection.',
 
 
   'services.service.config.configHistory.configGroup': 'Group',
   'services.service.config.configHistory.configGroup': 'Group',
-  'services.service.config.configHistory.makeCurrent.message': 'Are you sure you want to make {0} the current version for {1}:{2} ?',
+  'services.service.config.configHistory.makeCurrent.message': 'Created from service config version {0}',
 
 
   'services.add.header':'Add Service Wizard',
   'services.add.header':'Add Service Wizard',
   'services.reassign.header':'Move Master Wizard',
   'services.reassign.header':'Move Master Wizard',
@@ -2000,6 +2000,7 @@ Em.I18n.translations = {
   'dashboard.configHistory.info-bar.changesToHandle': 'Changes to handle',
   'dashboard.configHistory.info-bar.changesToHandle': 'Changes to handle',
   'dashboard.configHistory.info-bar.showMore': 'Show more',
   'dashboard.configHistory.info-bar.showMore': 'Show more',
   'dashboard.configHistory.info-bar.save.popup.title': 'Save Configuration',
   'dashboard.configHistory.info-bar.save.popup.title': 'Save Configuration',
+  'dashboard.configHistory.info-bar.makeCurrent.popup.title': 'Make Current Confirmation',
   'dashboard.configHistory.info-bar.save.popup.placeholder': 'What did you change?',
   'dashboard.configHistory.info-bar.save.popup.placeholder': 'What did you change?',
   'dashboard.configHistory.info-bar.revert.button': 'Make current',
   'dashboard.configHistory.info-bar.revert.button': 'Make current',
 
 

+ 26 - 6
ambari-web/app/views/common/configs/config_history_flow.js

@@ -245,14 +245,33 @@ App.ConfigHistoryFlowView = Em.View.extend({
     if (isDisabled) return;
     if (isDisabled) return;
     var serviceConfigVersion = event.context || Em.Object.create({
     var serviceConfigVersion = event.context || Em.Object.create({
       version: this.get('displayedServiceVersion.version'),
       version: this.get('displayedServiceVersion.version'),
-      serviceName: this.get('displayedServiceVersion.serviceName')
+      serviceName: this.get('displayedServiceVersion.serviceName'),
+      notes:''
     });
     });
     var versionText = event.context ? event.context.get('versionText') : this.get('displayedServiceVersion.versionText');
     var versionText = event.context ? event.context.get('versionText') : this.get('displayedServiceVersion.versionText');
-    App.showConfirmationPopup(function () {
+    var configGroupName = this.get('displayedServiceVersion.configGroupName');
+    return App.ModalPopup.show({
+      header: Em.I18n.t('dashboard.configHistory.info-bar.makeCurrent.popup.title'),
+      serviceConfigNote: Em.I18n.t('services.service.config.configHistory.makeCurrent.message').format(versionText),
+      bodyClass: Em.View.extend({
+        templateName: require('templates/common/configs/save_configuration'),
+        notesArea: Em.TextArea.extend({
+          classNames: ['full-width'],
+          value: Em.I18n.t('services.service.config.configHistory.makeCurrent.message').format(versionText),
+          onChangeValue: function() {
+            this.get('parentView.parentView').set('serviceConfigNote', this.get('value'));
+          }.observes('value')
+        })
+      }),
+      primary: Em.I18n.t('dashboard.configHistory.info-bar.revert.button'),
+      secondary: Em.I18n.t('common.discard'),
+      third: Em.I18n.t('common.cancel'),
+      onPrimary: function () {
+        serviceConfigVersion.set('serviceConfigNote', this.get('serviceConfigNote'));
         self.sendRevertCall(serviceConfigVersion);
         self.sendRevertCall(serviceConfigVersion);
-      },
-      Em.I18n.t('services.service.config.configHistory.makeCurrent.message').format(versionText, this.get('displayedServiceVersion.serviceName'), this.get('displayedServiceVersion.configGroupName'))
-    );
+        this.hide();
+      }
+    });
   },
   },
 
 
   /**
   /**
@@ -268,7 +287,8 @@ App.ConfigHistoryFlowView = Em.View.extend({
           "Clusters": {
           "Clusters": {
             "desired_serviceconfigversions": {
             "desired_serviceconfigversions": {
               "serviceconfigversion": serviceConfigVersion.get('version'),
               "serviceconfigversion": serviceConfigVersion.get('version'),
-              "service_name": serviceConfigVersion.get('serviceName')
+              "service_name": serviceConfigVersion.get('serviceName'),
+              "service_config_version_note": serviceConfigVersion.get('serviceConfigNote')
             }
             }
           }
           }
         }
         }