AMBARI-16442 VDF UI edits and bugs: #2 (zhewang)

ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js

@@ -224,10 +224,11 @@ angular.module('ambariAdminConsole')
         angular.forEach(data.repository_versions[0].RepositoryVersions.stack_services, function (service) {
           services.push({
             name: service.name,
-            version: service.versions[0]
+            version: service.versions[0],
+            displayName: service.display_name
           });
         });
-        response.services = services;
+        response.services = services.sort(function(a, b){return a.name.localeCompare(b.name)});
         deferred.resolve(response);
       })
       .error(function (data) {

ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css

@@ -1630,4 +1630,8 @@ thead.view-permission-header > tr > th {
     border-bottom: 2px solid #ddd;
     padding-bottom: 10px;
     margin-top: 5px;
+}
+
+.glyphicon-question-sign {
+  color: #0572ff;
 }

ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html

@@ -23,7 +23,7 @@
     <li class="active" ng-if="createController">{{'versions.register' | translate}}</li>
   </ol>
 
-  <div class="pull-right top-margin-4">
+  <div class="pull-right top-margin-4" ng-if="editController">
     <a href="#/stackVersions/create" class="btn btn-primary">
       <span class="glyphicon glyphicon-plus"></span>
         {{'versions.register' | translate}}
@@ -142,7 +142,7 @@
       <div class="col-sm-6 version-contents-section">
         <div class="alert alert-info hide-soft" ng-class="{'visible' : !services || !services.length}" role="alert">{{'versions.contents.empty' | translate}}</div>
         <div class="clearfix" ng-repeat="service in services">
-          <div class="version-info col-sm-9">{{service.name}} ({{service.version}})</div>
+          <div class="version-info col-sm-9">{{service.displayName}} ({{service.version}})</div>
         </div>
       </div>
     </div>

ambari-web/app/controllers/installer.js

@@ -442,6 +442,10 @@ App.InstallerController = App.WizardController.extend({
     App.db.setStacks(stacks.slice());
     this.set('content.stacks', stacks);
 
+    App.OperatingSystem.find().filterProperty('isSelected', false).map(function (os) {
+      os.deleteRecord();
+      App.store.commit();
+    });
     var repos = App.Repository.find() || [];
     App.db.setRepos(repos.slice());
   },

ambari-web/app/mappers/repository_version_mapper.js

@@ -35,9 +35,9 @@ App.repoVersionMapper = App.QuickDataMapper.create({
       stack_version_type: repoVersionsKey + '.stack_name',
       stack_version_number: repoVersionsKey + '.stack_version',
       use_redhat_satellite: 'use_redhat_satellite',
-      services_key: 'services',
-      services_type: 'array',
-      services: {
+      stack_services_key: 'stack_services',
+      stack_services_type: 'array',
+      stack_services: {
         item: 'id'
       },
       operating_systems_key: 'operating_systems',
@@ -118,24 +118,24 @@ App.repoVersionMapper = App.QuickDataMapper.create({
               resultOS.push(this.parseIt(os, this.get('modelOS')));
             }, this);
           }
-          if (item[repoVersionsKey].services) {
-            item[repoVersionsKey].services.forEach(function (service) {
+          if (item[repoVersionsKey].stack_services) {
+            item[repoVersionsKey].stack_services.forEach(function (service) {
               var serviceObj = {
                 id: service.name,
                 name: service.name,
                 display_name: service.display_name,
-                latest_version: service.versions[0] ? service.versions[0].version : ''
+                latest_version: service.versions[0] ? service.versions[0] : ''
               };
               serviceArray.pushObject(serviceObj);
               resultService.push(this.parseIt(serviceObj, this.get('modelService')));
             }, this);
-          } else if (item[repoVersionsKey].stack_services) {
-            item[repoVersionsKey].stack_services.forEach(function (service) {
+          } else if (item[repoVersionsKey].services) {
+            item[repoVersionsKey].services.forEach(function (service) {
               var serviceObj = {
                 id: service.name,
                 name: service.name,
                 display_name: service.display_name,
-                latest_version: service.versions[0] ? service.versions[0]: ''
+                latest_version: service.versions[0] ? service.versions[0].version: ''
               };
               serviceArray.pushObject(serviceObj);
               resultService.push(this.parseIt(serviceObj, this.get('modelService')));
@@ -143,7 +143,7 @@ App.repoVersionMapper = App.QuickDataMapper.create({
           }
           repo.use_redhat_satellite = item.operating_systems[0].OperatingSystems.ambari_managed_repositories === false;
           repo.operating_systems = osArray;
-          repo.services = serviceArray;
+          repo.stack_services = serviceArray;
           resultRepoVersion.push(this.parseIt(repo, this.modelRepoVersion(isCurrentStackOnly)));
         }
       }, this);

ambari-web/app/models/stack_version/repository_version.js

@@ -27,7 +27,7 @@ App.RepositoryVersion = DS.Model.extend({
   stackVersionNumber: DS.attr('string'),
   useRedhatSatellite: DS.attr('boolean'),
   operatingSystems: DS.hasMany('App.OS'),
-  services: DS.hasMany('App.ServiceSimple'),
+  stackServices: DS.hasMany('App.ServiceSimple'),
   stackVersion: DS.belongsTo('App.StackVersion'),
   stack: Em.computed.concat(' ', 'stackVersionType', 'stackVersionNumber'),
   displayNameSimple: function() {

ambari-web/app/styles/application.less

@@ -6350,9 +6350,6 @@ input[type="radio"].align-checkbox, input[type="checkbox"].align-checkbox {
       margin-top: 13px;
     }
     #use-redhat, #skip-validation {
-      .icon-question-sign {
-        color: #0572ff;
-      }
       input{
         margin: 0px 10px;
       }

ambari-web/app/styles/stack_versions.less

@@ -121,9 +121,6 @@
         margin-right: 8px;
         margin-top: 0;
       }
-      .icon-question-sign {
-        color: @blue;
-      }
     }
   }
 }
@@ -672,9 +669,13 @@
       margin-right: 8px;
       margin-top: 0;
     }
-    .icon-question-sign {
-      color: @blue;
-    }
+  }
+}
+
+#skip-validation,
+#use-redhat {
+  .icon-question-sign {
+    color: @blue;
   }
 }
 

ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js

@@ -42,7 +42,7 @@ App.UpgradeVersionColumnView = App.UpgradeVersionBoxView.extend({
 
   services: function() {
     var repoRecord = App.RepositoryVersion.find(this.get('content.id'));
-    var originalServices = repoRecord.get('services');
+    var originalServices = repoRecord.get('stackServices');
     // sort the services in the order the same as service menu
     var sorted = App.Service.find().map(function (service) {
       var latestVersion = '';