AMBARI-13965. Ambari CS View "Ambari Cluster URL" setting regex is too restrictive. (DIPAYAN BHOWMICK via Jaimin)

contrib/views/capacity-scheduler/pom.xml

@@ -68,6 +68,11 @@
             <artifactId>commons-codec</artifactId>
             <version>1.9</version>
         </dependency>
+        <dependency>
+          <groupId>commons-validator</groupId>
+          <artifactId>commons-validator</artifactId>
+          <version>1.4.1</version>
+        </dependency>
         <dependency>
             <groupId>org.apache.ambari</groupId>
             <artifactId>ambari-views</artifactId>

contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/PropertyValidator.java

@@ -21,14 +21,17 @@ package org.apache.ambari.view.capacityscheduler;
 import org.apache.ambari.view.ViewInstanceDefinition;
 import org.apache.ambari.view.validation.ValidationResult;
 import org.apache.ambari.view.validation.Validator;
+import org.apache.commons.validator.routines.RegexValidator;
+import org.apache.commons.validator.routines.UrlValidator;
 
 import java.net.MalformedURLException;
-import java.net.URISyntaxException;
 import java.net.URL;
 
 public class PropertyValidator implements Validator {
 
   public static final String AMBARI_SERVER_URL = "ambari.server.url";
+  public static final String PATH_REGEX = "/api/v1/clusters/\\w+";
+  public static final String AUTHORITY_REGEX = "^[a-zA-Z0-9]+([\\-\\.]{1}[a-zA-Z0-9]+)*(:[0-9]{1,5}){1}$";
 
   @Override
   public ValidationResult validateInstance(ViewInstanceDefinition viewInstanceDefinition, ValidationContext validationContext) {
@@ -44,14 +47,33 @@ public class PropertyValidator implements Validator {
     if (property.equals(AMBARI_SERVER_URL)) {
       String ambariServerUrl = viewInstanceDefinition.getPropertyMap().get(AMBARI_SERVER_URL);
 
-      if (!ambariServerUrl.matches("^https?://[\\w\\d\\.]+:\\d+/api/v1/clusters/\\w+$")) {
+      if (!(validateUrl(new String[] {"http", "https"}, ambariServerUrl)
+        && validatePortAndPath(PATH_REGEX, ambariServerUrl))) {
         return new InvalidPropertyValidationResult(false,
-            "URL should contain protocol, hostname, port, cluster name, e.g. http://ambari.server:8080/api/v1/clusters/MyCluster");
+          "URL should contain protocol, hostname, port, cluster name, e.g. http://ambari.server:8080/api/v1/clusters/MyCluster");
       }
     }
     return ValidationResult.SUCCESS;
   }
 
+  private boolean validatePortAndPath(String pathRegex, String urlString) {
+    try {
+      URL url = new URL(urlString);
+      String path = url.getPath();
+      int port = url.getPort();
+      return path.matches(pathRegex) && (port != -1);
+    } catch (MalformedURLException e) {
+      // Unreachable as this will not be called if the URL is not valid
+    }
+    return false;
+  }
+
+  private boolean validateUrl(String[] schemas, String urlString) {
+    RegexValidator authorityValidator = new RegexValidator(AUTHORITY_REGEX);
+    UrlValidator validator = new UrlValidator(schemas, authorityValidator, UrlValidator.ALLOW_LOCAL_URLS);
+    return validator.isValid(urlString);
+  }
+
   public static class InvalidPropertyValidationResult implements ValidationResult {
     private boolean valid;
     private String detail;

contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/PropertyValidatorTest.java

@@ -119,6 +119,40 @@ public class PropertyValidatorTest {
         Validator.ValidationContext.PRE_CREATE).isValid());
   }
 
+  @Test
+  public void shouldValidateUrlsWithHyphenInHostName() throws Exception {
+    ViewInstanceDefinition instanceDefinition =
+      getViewInstanceDefinition("http://sub-domain.hostname.com:8080/api/v1/clusters/Cluster");
+    PropertyValidator propertyValidator = new PropertyValidator();
+
+    assertTrue(propertyValidator.validateProperty(
+      PropertyValidator.AMBARI_SERVER_URL, instanceDefinition,
+      Validator.ValidationContext.PRE_CREATE).isValid());
+  }
+
+  @Test
+  public void shouldValidateUrlWithNonStandardTLDs() throws Exception {
+    ViewInstanceDefinition instanceDefinition =
+      getViewInstanceDefinition("http://cl1-node.nova:8080/api/v1/clusters/Cluster");
+    PropertyValidator propertyValidator = new PropertyValidator();
+
+    assertTrue(propertyValidator.validateProperty(
+      PropertyValidator.AMBARI_SERVER_URL, instanceDefinition,
+      Validator.ValidationContext.PRE_CREATE).isValid());
+  }
+
+  @Test
+  public void shouldValidateLocalhost() throws Exception {
+    ViewInstanceDefinition instanceDefinition =
+      getViewInstanceDefinition("http://localhost:8080/api/v1/clusters/Cluster");
+    PropertyValidator propertyValidator = new PropertyValidator();
+
+    assertTrue(propertyValidator.validateProperty(
+      PropertyValidator.AMBARI_SERVER_URL, instanceDefinition,
+      Validator.ValidationContext.PRE_CREATE).isValid());
+
+  }
+
   private ViewInstanceDefinition getViewInstanceDefinition(String ambariServerUrl) {
     ViewInstanceDefinition instanceDefinition = createNiceMock(ViewInstanceDefinition.class);
     Map<String, String> map = new HashMap<String, String>();