AMBARI-11878 Kerberos Wizard: Configure kerberos step infinite spinner shown.(ababiichuk)

ambari-web/app/controllers/main/admin/kerberos/step2_controller.js

@@ -67,6 +67,7 @@ App.KerberosWizardStep2Controller = App.WizardStep7Controller.extend({
 
   clearStep: function () {
     this._super();
+    this.set('configs', []);
     this.get('serviceConfigTags').clear();
     this.set('servicesInstalled', false);
   },
@@ -78,9 +79,10 @@ App.KerberosWizardStep2Controller = App.WizardStep7Controller.extend({
    */
   loadStep: function () {
     console.log("TRACE: Loading step7: Configure Services");
+    if (!App.StackService.find().someProperty('serviceName', 'KERBEROS') || !this.get('isConfigsLoaded')) {
+      return;
+    }
     this.clearStep();
-    var kerberosStackService = App.StackService.find().findProperty('serviceName', 'KERBEROS');
-    if (!kerberosStackService) return;
     //STEP 1: Load advanced configs
     var advancedConfigs = this.get('content.advancedServiceConfig');
     //STEP 2: Load on-site configs by service from local DB

ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js

@@ -180,7 +180,7 @@ App.KerberosWizardController = App.WizardController.extend({
    * @param newValue
    */
   overrideVisibility: function (itemsArray, newValue, exceptions) {
-    newValue = newValue || false
+    newValue = newValue || false;
 
     for (var i = 0, len = itemsArray.length; i < len; i += 1) {
       if (!Ember.$.isEmptyObject(itemsArray[i])) {

ambari-web/app/mixins/common/serverValidator.js

@@ -114,6 +114,10 @@ App.ServerValidatorMixin = Em.Mixin.create({
    * @returns {*}
    */
   loadServerSideConfigsRecommendations: function() {
+    // if extended controller doesn't support recommendations ignore this call but keep promise chain
+    if (!this.get('isControllerSupportsEnhancedConfigs')) {
+      return $.Deferred().resolve().promise();
+    }
     return App.ajax.send({
       'name': 'config.recommendations',
       'sender': this,

ambari-web/app/utils/config.js

@@ -523,7 +523,7 @@ App.config = Em.Object.create({
           if (_preDefinedConfig.serviceName != 'MISC' && _preDefinedConfig.filename && !configTypes.contains(self.getConfigTagFromFileName(_preDefinedConfig.filename))) {
             return;
           }
-          preDefinedCfgs.push(_preDefinedConfig);
+          preDefinedCfgs.push($.extend(true, {}, _preDefinedConfig));
         }
       }, this);
 

ambari-web/test/mixins/common/serverValidator_test.js

@@ -130,5 +130,50 @@ describe('App.ServerValidatorMixin', function() {
       });
     });
   });
+
+  describe('#loadServerSideConfigsRecommendations', function() {
+    describe('Request on recommendations for only specified controllers', function() {
+      beforeEach(function() {
+        sinon.stub(App.ajax, 'send', function(args) { return args; });
+      });
+
+      afterEach(function() {
+        App.ajax.send.restore();
+      });
+
+      [
+        {
+          controllerName: '',
+          injectEnhancedConfigsMixin: false,
+          e: false
+        },
+        {
+          controllerName: 'wizardStep7Controller',
+          injectEnhancedConfigsMixin: true,
+          e: true
+        },
+        {
+          controllerName: 'kerberosWizardStep2Controller',
+          injectEnhancedConfigsMixin: true,
+          e: false
+        }
+      ].forEach(function(test) {
+        it('controller "name": {0} using "EnhancedConfigsMixin": {1} recommendations called: {2}'.format(test.controllerName, test.injectEnhancedConfigsMixin, test.e), function() {
+          var mixed;
+          if (test.injectEnhancedConfigsMixin) {
+            mixed = Em.Object.extend(App.EnhancedConfigsMixin, App.ServerValidatorMixin);
+          } else {
+            mixed = Em.Object.extend(App.ServerValidatorMixin);
+          }
+          // mock controller name in mixed object directly
+          mixed.create({name: test.controllerName}).loadServerSideConfigsRecommendations();
+          expect(App.ajax.send.calledOnce).to.be.eql(test.e);
+          if (test.e) {
+            expect(App.ajax.send.args[0][0].name).to.be.eql('config.recommendations');
+          }
+        });
+      });
+    });
+  });
 });