AMBARI-13672. HistoryServer fails to start due to permissions issue (umask 027) (aonishuk)

ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py

@@ -35,7 +35,7 @@ STACK_VERSION_PATTERN = "{{ stack_version }}"
 
 TARBALL_MAP = {
   "HDP": {
-    "slider":      ("/usr/hdp/{0}/slider/slider.tar.gz".format(STACK_VERSION_PATTERN),
+    "slider":      ("/usr/hdp/{0}/slider/lib/slider.tar.gz".format(STACK_VERSION_PATTERN),
                   "/hdp/apps/{0}/slider/slider.tar.gz".format(STACK_VERSION_PATTERN)),    
     "tez":       ("/usr/hdp/{0}/tez/lib/tez.tar.gz".format(STACK_VERSION_PATTERN),
                   "/hdp/apps/{0}/tez/tez.tar.gz".format(STACK_VERSION_PATTERN)),

ambari-common/src/main/python/resource_management/libraries/functions/get_user_call_output.py

@@ -23,6 +23,8 @@ Ambari Agent
 import os
 import tempfile
 from resource_management.core import shell
+from resource_management.core.logger import Logger
+from resource_management.core.exceptions import Fail
 
 def get_user_call_output(command, user, quiet=False, is_checked_call=True, **call_kwargs):
   """
@@ -45,14 +47,22 @@ def get_user_call_output(command, user, quiet=False, is_checked_call=True, **cal
     command_string += " 1>" + out_files[0].name
     command_string += " 2>" + out_files[1].name
     
-    func = shell.checked_call if is_checked_call else shell.call
-    func_result = func(shell.as_user(command_string, user), quiet=quiet, **call_kwargs)
+    code, _ = shell.call(shell.as_user(command_string, user), quiet=quiet, **call_kwargs)
     
     files_output = []
     for f in out_files:
       files_output.append(f.read().strip('\n'))
+      
+    if code:
+      all_output = files_output[1] + '\n' + files_output[0]
+      err_msg = Logger.filter_text(("Execution of '%s' returned %d. %s") % (command_string, code, all_output))
+      
+      if is_checked_call:
+        raise Fail(err_msg)
+      else:
+        Logger.warning(err_msg)      
     
-    return func_result[0], files_output[0], files_output[1]
+    return code, files_output[0], files_output[1]
   finally:
     for f in out_files:
       f.close()

ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py

@@ -37,8 +37,8 @@ if Script.is_hdp_stack_greater_or_equal("2.2"):
 slider_conf_dir = format("{slider_home_dir}/conf")
 storm_slider_conf_dir = '/usr/hdp/current/storm-slider-client/conf'
 
-slider_tar_gz = format('{slider_home_dir}/slider.tar.gz')
 slider_lib_dir = format('{slider_home_dir}/lib')
+slider_tar_gz = format('{slider_lib_dir}/slider.tar.gz')
 
 user_group = config['configurations']['cluster-env']['user_group']
 hdfs_user = config['configurations']['hadoop-env']['hdfs_user']

ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py

@@ -81,7 +81,7 @@ def slider():
          mode=0644
     )
   if Script.is_hdp_stack_greater_or_equal("2.2"): 
-    Execute(('tar', '-czvf', params.slider_tar_gz, '--exclude=slider-core*.jar', params.slider_lib_dir),
-            not_if = format('test -f {slider_tar_gz}'),
-            sudo = True,
+    File(params.slider_tar_gz,
+         owner=params.hdfs_user,
+         group=params.user_group,
     )

ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py

@@ -66,13 +66,9 @@ class TestSliderClient(RMFTestCase):
                               mode=0644,
                               content='log4jproperties\nline2'
     )
-    self.assertResourceCalled('Execute', ('tar',
-     '-czvf',
-     '/usr/hdp/current/slider-client/slider.tar.gz',
-     '--exclude=slider-core*.jar',
-     '/usr/hdp/current/slider-client/lib'),
-        not_if = 'test -f /usr/hdp/current/slider-client/slider.tar.gz',
-        sudo = True,
+    self.assertResourceCalled('File', '/usr/hdp/current/slider-client/lib/slider.tar.gz',
+        owner = 'hdfs',
+        group = 'hadoop',
     )
 
     self.assertNoMoreResources()