AMBARI-5793. When provisioning cluster via a bluprint, in some cases not all missing passwords reported to user

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java

@@ -891,7 +891,6 @@ public class ClusterResourceProvider extends AbstractControllerResourceProvider
     // AMBARI-4921
     ensureProperty("global", "user_group", "hadoop");
     ensureProperty("global", "nagios_contact", "default@REPLACEME.NOWHERE");
-    ensureProperty("global", "nagios_web_password", "admin");
     ensureProperty("global", "smokeuser", "ambari-qa");
 
     // AMBARI-5206

ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java

@@ -228,9 +228,13 @@ public class BlueprintEntity {
 
         requiredProperties.removeAll(operationalTypeProps);
         if (! requiredProperties.isEmpty()) {
-          Map<String, Collection<String>> hostGroupMissingProps = new HashMap<String, Collection<String>>();
+          String hostGroupName = hostGroup.getName();
+          Map<String, Collection<String>> hostGroupMissingProps = missingProperties.get(hostGroupName);
+          if (hostGroupMissingProps == null) {
+            hostGroupMissingProps = new HashMap<String, Collection<String>>();
+            missingProperties.put(hostGroupName, hostGroupMissingProps);
+          }
           hostGroupMissingProps.put(requiredCategory, requiredProperties);
-          missingProperties.put(hostGroup.getName(), hostGroupMissingProps);
         }
       }
     }

ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java

@@ -434,11 +434,10 @@ public class ClusterResourceProviderTest {
     mapConfigRequests.put(cr3.getType(), cr3);
     assertEquals(3, mapConfigRequests.size());
     ConfigurationRequest globalConfigRequest = mapConfigRequests.get("global");
-    assertEquals(5, globalConfigRequest.getProperties().size());
+    assertEquals(4, globalConfigRequest.getProperties().size());
     assertEquals("hadoop", globalConfigRequest.getProperties().get("user_group"));
     assertEquals("ambari-qa", globalConfigRequest.getProperties().get("smokeuser"));
     assertEquals("default@REPLACEME.NOWHERE", globalConfigRequest.getProperties().get("nagios_contact"));
-    assertEquals("admin", globalConfigRequest.getProperties().get("nagios_web_password"));
     assertEquals("oozie", globalConfigRequest.getProperties().get("oozie_user"));
     ConfigurationRequest hdfsConfigRequest = mapConfigRequests.get("hdfs-site");
     assertEquals(1, hdfsConfigRequest.getProperties().size());
@@ -1504,11 +1503,10 @@ public class ClusterResourceProviderTest {
     mapConfigRequests.put(cr3.getType(), cr3);
     assertEquals(3, mapConfigRequests.size());
     ConfigurationRequest globalConfigRequest = mapConfigRequests.get("global");
-    assertEquals(5, globalConfigRequest.getProperties().size());
+    assertEquals(4, globalConfigRequest.getProperties().size());
     assertEquals("hadoop", globalConfigRequest.getProperties().get("user_group"));
     assertEquals("ambari-qa", globalConfigRequest.getProperties().get("smokeuser"));
     assertEquals("default@REPLACEME.NOWHERE", globalConfigRequest.getProperties().get("nagios_contact"));
-    assertEquals("admin", globalConfigRequest.getProperties().get("nagios_web_password"));
     assertEquals("oozie", globalConfigRequest.getProperties().get("oozie_user"));
     ConfigurationRequest hdfsConfigRequest = mapConfigRequests.get("hdfs-site");
     assertEquals(1, hdfsConfigRequest.getProperties().size());

ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java

@@ -89,7 +89,7 @@ public class BlueprintEntityTest {
     prop.setRequireInput(true);
     prop.setType(PropertyInfo.PropertyType.PASSWORD);
     prop.setValue(null);
-    requiredProps.put("service1", prop);
+    requiredProps.put("super.secret.password", prop);
 
     BlueprintEntity entity = new BlueprintEntity();
     entity.setStackName("stackName");
@@ -112,6 +112,7 @@ public class BlueprintEntityTest {
 
     Collection<HostGroupEntity> hostGroupEntities = new HashSet<HostGroupEntity>();
     HostGroupEntity hostGroupEntity = new HostGroupEntity();
+    hostGroupEntity.setName("group1");
     Collection<HostGroupComponentEntity> hostGroupComponents = new HashSet<HostGroupComponentEntity>();
     HostGroupComponentEntity componentEntity = new HostGroupComponentEntity();
     componentEntity.setName("component1");
@@ -148,7 +149,7 @@ public class BlueprintEntityTest {
     prop.setRequireInput(true);
     prop.setType(PropertyInfo.PropertyType.PASSWORD);
     prop.setValue(null);
-    requiredProps.put("service1", prop);
+    requiredProps.put("super.secret.password", prop);
 
     BlueprintEntity entity = new BlueprintEntity();
     entity.setStackName("stackName");
@@ -158,6 +159,7 @@ public class BlueprintEntityTest {
 
     Collection<HostGroupEntity> hostGroupEntities = new HashSet<HostGroupEntity>();
     HostGroupEntity hostGroupEntity = new HostGroupEntity();
+    hostGroupEntity.setName("group1");
     Collection<HostGroupComponentEntity> hostGroupComponents = new HashSet<HostGroupComponentEntity>();
     HostGroupComponentEntity componentEntity = new HostGroupComponentEntity();
     componentEntity.setName("component1");
@@ -208,7 +210,16 @@ public class BlueprintEntityTest {
     prop.setRequireInput(true);
     prop.setType(PropertyInfo.PropertyType.PASSWORD);
     prop.setValue(null);
-    requiredProps.put("service1", prop);
+
+    PropertyInfo prop2 = new PropertyInfo();
+    prop2.setFilename("global.xml");
+    prop2.setName("another.super.secret.password");
+    prop2.setRequireInput(true);
+    prop2.setType(PropertyInfo.PropertyType.PASSWORD);
+    prop2.setValue(" ");
+
+    requiredProps.put("super.secret.password", prop);
+    requiredProps.put("another.super.secret.password", prop2);
 
     BlueprintEntity entity = new BlueprintEntity();
     entity.setStackName("stackName");
@@ -231,12 +242,13 @@ public class BlueprintEntityTest {
 
     Collection<HostGroupEntity> hostGroupEntities = new HashSet<HostGroupEntity>();
     HostGroupEntity hostGroupEntity = new HostGroupEntity();
+    hostGroupEntity.setName("hg1");
     Collection<HostGroupComponentEntity> hostGroupComponents = new HashSet<HostGroupComponentEntity>();
     HostGroupComponentEntity componentEntity = new HostGroupComponentEntity();
     componentEntity.setName("component1");
     componentEntity.setBlueprintName("blueprint");
     componentEntity.setHostGroupEntity(hostGroupEntity);
-    componentEntity.setHostGroupName("group1");
+    componentEntity.setHostGroupName("hg1");
     hostGroupComponents.add(componentEntity);
     hostGroupEntity.setComponents(hostGroupComponents);
     hostGroupEntity.setConfigurations(Collections.<HostGroupConfigEntity>emptyList());
@@ -252,6 +264,13 @@ public class BlueprintEntityTest {
         metaInfo, PropertyInfo.PropertyType.PASSWORD);
 
     assertEquals(1, missingProps.size());
+    Map<String, Collection<String>> typeProps = missingProps.get("hg1");
+    assertEquals(2, typeProps.size());
+    assertEquals(1, typeProps.get("global").size());
+    assertEquals(1, typeProps.get("core-site").size());
+
+    assertTrue(typeProps.get("core-site").contains("super.secret.password"));
+    assertTrue(typeProps.get("global").contains("another.super.secret.password"));
 
     verify(metaInfo);
   }